Re: [PATCH 3/3] SConstruct: Use 'target' option to decide whenewer to restart systemd

[Gary E. Miller]

Yo Ladislav!

As I have already pointed out several times.  This patch conflates
scons option "target" with the concept of "cross compiling". "target"
is just the directory of the tool chain to use (cc, ld, nm, etc.).  It
says nothing about whether or not one is cross-compiling or whether a
"systemctl daemon-reload" should be run on install.

I have updated "scons -h" to try to make the "target" and "sysroot"
options more clear.

Right now gpsd has no option that says "I am cross-compiling".  It only
has the option to use toolchains that are not the default system tool
chain.  An optional tool chain may, or may not be, a cross-compiler.

Maybe gpsd needs an "I am cross-compiling" option?

As it stands now, if systemd if not found, or the scons options
systemd=False is set, then the "systemctl daemon-reload" is not run.

I assume that you want systemd=True, so that the systemd files get
installed in DESTDIR.  But you do not want "systemctl daemon-reload" to
run.  Reloading the daemon is benign, having zero bad side effects.  But
for OCD purposes, maybe improving the situtation is worth effort.

Since I don't run systemd, maybe a systemd person can ponder the
problem and give us their thoughts.


On Sun, 2 Feb 2020 10:44:43 +0100
Ladislav Michl <address@hidden> wrote:

> Besides gpsd is able to cross-compile without sysroot option, it makes
> this cross-compile check aligned with the one for sizeof(time_t).
> ---
>  SConstruct | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/SConstruct b/SConstruct
> index 65e649d32..c49bb8476 100644
> --- a/SConstruct
> +++ b/SConstruct
> @@ -2753,7 +2753,7 @@ udev_install = Utility('udev-install',
> 'install', [ 
>  if env['systemd']:
>      env.Requires(udev_install, systemd_install)
> -    if not env["sysroot"]:
> +    if not env['target']:
>          systemctl_daemon_reload = Utility('systemctl-daemon-reload',
> '', ['systemctl daemon-reload || true'])
>          env.AlwaysBuild(systemctl_daemon_reload)




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

pgpH52UGn8m8n.pgp
Description: OpenPGP digital signature