Re: [PATCH 3/3] SConstruct: Use 'target' option to decide whenewer to restart systemd

[Ladislav Michl]

Hello Gary,

On Tue, Feb 04, 2020 at 02:05:44PM -0800, Gary E. Miller wrote:
> Yo Ladislav!
> 
> On Tue, 4 Feb 2020 01:44:06 +0100
> Ladislav Michl <address@hidden> wrote:
> 
> > > and in general if we have a "are we cross compiling" variable and
> > > then switch things on it, when that makes sense, it seems like life
> > > will be simpler.  
> > 
> > I know I'm stepping on thin ice, but... In autotools world, whenever
> 
> Yes, thin ice.  gpsd excised autotools a long time ago.
> 
> > --host option different from --build is given, that means
> > cross-compiling.
> > https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/Specifying-Target-Triplets.html
> > 
> > Gpsd'd 'target' option seemed to serve this purpose to me.
> 
> But does not match the help:
> 
> scons -h:
> 
> " target: Directory containing the binary tools to use (gcc, ld, etc.) "
> " Useful for cross-compiling, or building with multiple local toolchains. "
> 
> So if you want to misread that, fine, but patches depending on that
> misreading will be rejected.

That help text claims 'target' is a directory, but SConstruct does not
handle it as such.

> > So what about introducing internal variable first, so we can
> > make decision on a clear logic, and decide lated how to feed
> > this variable.
> 
> Cart, horse, backwards.
> 
> > Of course that could easily wait after release.
> 
> No release in sight.  Let's get it right the first time.
> 
> And to step back a bit, why do you care if "systemd reload" is run
> or not?  Zero side effects.  Isn't there a real bug worth fixing
> somewhere?

I bet there are tons of bugs to be fixed and I started with those
which prevented me to cross-compile gpsd without solving installation
outside SConstruct. Even started with low hanging fruit...
(and I'll resist asking what "real" means here)

Best regards,
        ladis