gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] SConstruct: Use 'target' option to decide whenewer to re


From: Gary E. Miller
Subject: Re: [PATCH 3/3] SConstruct: Use 'target' option to decide whenewer to restart systemd
Date: Tue, 4 Feb 2020 14:05:44 -0800

Yo Ladislav!

On Tue, 4 Feb 2020 01:44:06 +0100
Ladislav Michl <address@hidden> wrote:

> > and in general if we have a "are we cross compiling" variable and
> > then switch things on it, when that makes sense, it seems like life
> > will be simpler.  
> 
> I know I'm stepping on thin ice, but... In autotools world, whenever

Yes, thin ice.  gpsd excised autotools a long time ago.

> --host option different from --build is given, that means
> cross-compiling.
> https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/Specifying-Target-Triplets.html
> 
> Gpsd'd 'target' option seemed to serve this purpose to me.

But does not match the help:

scons -h:

" target: Directory containing the binary tools to use (gcc, ld, etc.) "
" Useful for cross-compiling, or building with multiple local toolchains. "

So if you want to misread that, fine, but patches depending on that
misreading will be rejected.

> So what about introducing internal variable first, so we can
> make decision on a clear logic, and decide lated how to feed
> this variable.

Cart, horse, backwards.

> Of course that could easily wait after release.

No release in sight.  Let's get it right the first time.

And to step back a bit, why do you care if "systemd reload" is run
or not?  Zero side effects.  Isn't there a real bug worth fixing
somewhere?

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

Attachment: pgpOCinCJh5wS.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]