[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] ParseTreeRewriter refactoring

From: Stephen Compall
Subject: Re: [Help-smalltalk] ParseTreeRewriter refactoring
Date: Thu, 11 Jan 2007 11:56:25 -0600

On Thu, 2007-01-11 at 11:44 +0100, Paolo Bonzini wrote:
> If you can eliminate "visitor:" keyword by having them be mostly copies, 
> do it.  If you can eliminate "visitor:" and not have them be mostly 
> copies, even better...

I could do it by merging #visitNode:onMatch: and #visitArgument:onMatch:
into calls to #visitNode:withSearches:onMatch:.

The attached patch doesn't do it that way.

> Sure.  I don't have a clue what time zone you are in, so...

UTC-0600, meaning my last message was sent at 4:40 AM.  I should really
learn normal waking hours...

Stephen Compall

Attachment: visitNodeList-onMatch.diff
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]