lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 5621: Improve rehearsal mark position at beginning of staff (i


From: lemzwerg
Subject: Re: Issue 5621: Improve rehearsal mark position at beginning of staff (issue 547340043 by address@hidden)
Date: Sat, 14 Dec 2019 22:29:59 -0800

One early comment :-)


https://codereview.appspot.com/547340043/diff/575390044/lily/break-alignment-interface.cc
File lily/break-alignment-interface.cc (right):

https://codereview.appspot.com/547340043/diff/575390044/lily/break-alignment-interface.cc#newcode328
lily/break-alignment-interface.cc:328:
Break_alignable_interface::self_alignment_cis_breakable (SCM grob)
Well, the cis–trans pairing is IMHO only understandable for people who
have a Latin background (or come from Austria, since it was divided into
»Cisleithanien« and »Transleithanien« in the K. und K. era)...  As nice
as it is, I suggest that you find names that are easier to comprehend
for other people.

https://codereview.appspot.com/547340043/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]