Re: Advancing to Patch::review

[Michael Käppler]

Am 03.12.2020 um 12:46 schrieb Michael Käppler:
[snip]
> No, that step remains manually, if I'm not mistaken.
> IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors
> out') would have failed 'make test' already.
> As I understood the (old) process, setting a patch to 'Review' should
> not only require a 'passing' 'make check', but also
> a visual inspection of the results.
> So setting a MR to 'Review' automatically after passing 'make check'
> would be a policy change IMHO.
Just to clarify this part: I'm referring to the 'old' system, when
we did run 'make test' in CI.

So

"IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors
out') would have failed 'make test' in the old system, already."