[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!t
From: |
Philip Nienhuis |
Subject: |
[Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files |
Date: |
Sat, 28 Dec 2019 10:50:28 -0500 (EST) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0 |
Follow-up Comment #18, bug #41298 (project octave):
Thanks for testing.
A test for emptyness would be a first prerequisite, indeed :-) I should have
thought of it.
I tried tracking what happens during execution of
<pkg>/private/configure_make.m.
Building the .oct files happens in ./src but completely outside the scope of
configure_make.m itself; that just launches a shell in which make does its
thing, configure_make.m remains unaware that there may be subdirs containing
.cc files. After make did its thing there are just .oct files in the temp src/
directory (which is a prerequisite of pkg.m, it expects the binary modules
files there.)
As to statistics, statistics-1.4.1 doesn't install here due to an illegal "="
operator in an anonymous function in linkage.m.
Luckily instrument-control generates its own .cc-tst files.
But for other packages where .cc files live in subdirs of src/ some tricks are
needed. Maybe iterating over all subdirs except m4/ and autom4te.cache/ would
do it? Seems fragile to me nevertheless. Looking around on SF my perception is
that such package are rare anyway.
My stance is to just leave the complications of complicated packages to their
respective maintainers and not bother here. That is, not at this moment, but
maybe for Octave-7.x or perhaps by that time Andrew's packajoozle has taken
over.
I just want to help implement a very desirable feature for pkg.m that would
work for the vast majority of OF packages, hopefully in time for Octave-6.1.0.
It already helped to uncover bugs in the two packages I maintain.
Updated patch with emptyness check attached.
(file #48129)
_______________________________________________________
Additional Item Attachment:
File name: bug_41298_pkg_install_tests.v4.cset Size:4 KB
<https://savannah.gnu.org/file/bug_41298_pkg_install_tests.v4.cset?file_id=48129>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?41298>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, (continued)
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, John Donoghue, 2019/12/26
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2019/12/26
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, John Donoghue, 2019/12/26
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, John Donoghue, 2019/12/26
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2019/12/26
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2019/12/26
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, John Donoghue, 2019/12/26
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Mike Miller, 2019/12/26
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2019/12/27
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, John Donoghue, 2019/12/28
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files,
Philip Nienhuis <=
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2019/12/28
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, John Donoghue, 2019/12/28
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, Philip Nienhuis, 2019/12/28
- [Octave-bug-tracker] [bug #41298] pkg install: automatically extract %!tests and install both extracted and fixed test files, John Donoghue, 2019/12/29