[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc
From: |
Markus Mützel |
Subject: |
[Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc |
Date: |
Thu, 8 Feb 2024 10:35:09 -0500 (EST) |
Update of bug#65244 (group octave):
Status: None => Patch Reviewed
Operating System: GNU/Linux => Any
Planned Release: None => 10.1.0 (current default)
_______________________________________________________
Follow-up Comment #2:
This looks good to me. A great application of C++11 features to simplify the
code. Also a good opportunity to remove dead code. 👍
Tangentially related: Would it make sense to change the type of `myvidx` to
`octave_idx_type`? At least theoretically, `ar_in` could have more than
INT_MAX elements. But I guess the problem would explode much earlier.
Alternatively, would it make sense to add a check that `ar_in.numel ()`
doesn't exceed INT_MAX (or another reasonable limit)?
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?65244>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, Hendrik K, 2024/02/02
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc,
Markus Mützel <=
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, John W. Eaton, 2024/02/08
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, Markus Mützel, 2024/02/08
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, Hendrik K, 2024/02/08
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, Hendrik K, 2024/02/08
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, Markus Mützel, 2024/02/09
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, anonymous, 2024/02/09
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, Markus Mützel, 2024/02/09
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, anonymous, 2024/02/09
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, anonymous, 2024/02/09
- [Octave-bug-tracker] [bug #65244] Simplify code complexity of perms.cc, Markus Mützel, 2024/02/09