[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] egl-helpers: fix possible resource leak
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] egl-helpers: fix possible resource leak |
Date: |
Thu, 3 Mar 2016 12:19:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/03/2016 10:43, Gonglei wrote:
> CID 1352419, using g_strdup_printf instead of asprintf.
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> ui/egl-helpers.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
> index 54be44c..2da1930 100644
> --- a/ui/egl-helpers.c
> +++ b/ui/egl-helpers.c
> @@ -50,18 +50,15 @@ int qemu_egl_rendernode_open(void)
> continue;
> }
>
> - r = asprintf(&p, "/dev/dri/%s", e->d_name);
> - if (r < 0) {
> - return -1;
> - }
> + p = g_strdup_printf("/dev/dri/%s", e->d_name);
>
> r = open(p, O_RDWR | O_CLOEXEC | O_NOCTTY | O_NONBLOCK);
> if (r < 0) {
> - free(p);
> + g_free(p);
> continue;
> }
> fd = r;
> - free(p);
> + g_free(p);
> break;
> }
>
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak, (continued)
- [Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak, Gonglei, 2016/03/03
- [Qemu-devel] [PATCH 3/6] spice: fix coverity complains, Gonglei, 2016/03/03
- [Qemu-devel] [PATCH 5/6] spapr: fix possible Negative array index read, Gonglei, 2016/03/03
- [Qemu-devel] [PATCH 6/6] smbus: fix memory leak, Gonglei, 2016/03/03
- [Qemu-devel] [PATCH 1/6] egl-helpers: fix possible resource leak, Gonglei, 2016/03/03
- Re: [Qemu-devel] [PATCH 1/6] egl-helpers: fix possible resource leak,
Paolo Bonzini <=