[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] spice: fix coverity complains
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] spice: fix coverity complains |
Date: |
Thu, 3 Mar 2016 12:19:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/03/2016 10:43, Gonglei wrote:
> Remove the unnecessary NULL check.
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> ui/spice-display.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/ui/spice-display.c b/ui/spice-display.c
> index 242ab5f..1ffbec1 100644
> --- a/ui/spice-display.c
> +++ b/ui/spice-display.c
> @@ -769,9 +769,7 @@ static void display_mouse_define(DisplayChangeListener
> *dcl,
> SimpleSpiceDisplay *ssd = container_of(dcl, SimpleSpiceDisplay, dcl);
>
> qemu_mutex_lock(&ssd->lock);
> - if (c) {
> - cursor_get(c);
> - }
> + cursor_get(c);
> cursor_put(ssd->cursor);
> ssd->cursor = c;
> ssd->hot_x = c->hot_x;
>
Reviewed-by: Paolo Bonzini <address@hidden>
[Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 3/6] spice: fix coverity complains, Gonglei, 2016/03/03
- Re: [Qemu-devel] [PATCH 3/6] spice: fix coverity complains,
Paolo Bonzini <=
[Qemu-devel] [PATCH 5/6] spapr: fix possible Negative array index read, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 6/6] smbus: fix memory leak, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 1/6] egl-helpers: fix possible resource leak, Gonglei, 2016/03/03