[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] smbus: fix memory leak
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] smbus: fix memory leak |
Date: |
Thu, 3 Mar 2016 12:05:13 +0000 |
> Subject: Re: [PATCH 6/6] smbus: fix memory leak
>
>
>
> On 03/03/2016 10:43, Gonglei wrote:
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> > hw/i2c/smbus_eeprom.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
> > index 5b7bd89..83c6b27 100644
> > --- a/hw/i2c/smbus_eeprom.c
> > +++ b/hw/i2c/smbus_eeprom.c
> > @@ -156,4 +156,6 @@ void smbus_eeprom_init(I2CBus *smbus, int
> nb_eeprom,
> > qdev_prop_set_ptr(eeprom, "data", eeprom_buf + (i * 256));
> > qdev_init_nofail(eeprom);
> > }
> > +
> > + g_free(eeprom_buf);
> > }
> >
>
> This is wrong, eeprom_buf is passed to the device through qdev_prop_set_ptr.
>
Oops, right, NACK. Thanks!
Regards,
-Gonglei
- Re: [Qemu-devel] [PATCH 2/6] sheepdog: fix possible resouce leak and out-of-bounds access, (continued)
[Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 3/6] spice: fix coverity complains, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 5/6] spapr: fix possible Negative array index read, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 6/6] smbus: fix memory leak, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 1/6] egl-helpers: fix possible resource leak, Gonglei, 2016/03/03