[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak |
Date: |
Thu, 3 Mar 2016 12:19:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/03/2016 10:43, Gonglei wrote:
> Signed-off-by: Gonglei <address@hidden>
> ---
> backends/hostmem-file.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
> index fd59482..217f858 100644
> --- a/backends/hostmem-file.c
> +++ b/backends/hostmem-file.c
> @@ -51,11 +51,14 @@ file_backend_memory_alloc(HostMemoryBackend *backend,
> Error **errp)
> error_setg(errp, "-mem-path not supported on this host");
> #else
> if (!memory_region_size(&backend->mr)) {
> + gchar *path;
> backend->force_prealloc = mem_prealloc;
> + path = object_get_canonical_path(OBJECT(backend));
> memory_region_init_ram_from_file(&backend->mr, OBJECT(backend),
> - object_get_canonical_path(OBJECT(backend)),
> + path,
> backend->size, fb->share,
> fb->mem_path, errp);
> + g_free(path);
> }
> #endif
> }
>
Reviewed-by: Paolo Bonzini <address@hidden>
[Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak, Gonglei, 2016/03/03
- Re: [Qemu-devel] [PATCH 4/6] hostmem-file: fix memory leak,
Paolo Bonzini <=
[Qemu-devel] [PATCH 3/6] spice: fix coverity complains, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 5/6] spapr: fix possible Negative array index read, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 6/6] smbus: fix memory leak, Gonglei, 2016/03/03
[Qemu-devel] [PATCH 1/6] egl-helpers: fix possible resource leak, Gonglei, 2016/03/03