[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR |
Date: |
Wed, 16 Mar 2016 18:43:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 16.03.2016 14:13, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt <address@hidden>
>
> The masks weren't chosen nor applied properly. The architecture specifies
> that writes to AMR are masked by UAMOR for PR=1, otherwise AMOR for HV=0.
>
> The writes to UAMOR are masked by AMOR for HV=0
>
> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
> [clg: moved gen_spr_amr() prototype change to next patch ]
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
> target-ppc/translate_init.c | 74
> ++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 59 insertions(+), 15 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [PATCH v2 02/10] ppc: Add macros to register hypervisor mode SPRs, (continued)
- [Qemu-devel] [PATCH v2 01/10] ppc: Update SPR definitions, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 06/10] ppc: Initialize AMOR in PAPR mode, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 05/10] ppc: Add dummy SPR_IC for POWER8, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 03/10] ppc: Add a bunch of hypervisor SPRs to Book3s, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 04/10] ppc: Create cpu_ppc_set_papr() helper, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 10/10] ppc: A couple more dummy POWER8 Book4 regs, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 08/10] ppc: Add POWER8 IAMR register, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 09/10] ppc: Add dummy CIABR SPR, Cédric Le Goater, 2016/03/16