[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR |
Date: |
Mon, 21 Mar 2016 14:06:54 +1100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Mar 16, 2016 at 02:13:51PM +0100, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt <address@hidden>
>
> The masks weren't chosen nor applied properly. The architecture specifies
> that writes to AMR are masked by UAMOR for PR=1, otherwise AMOR for HV=0.
>
> The writes to UAMOR are masked by AMOR for HV=0
>
> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
> [clg: moved gen_spr_amr() prototype change to next patch ]
> Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> target-ppc/translate_init.c | 74
> ++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 59 insertions(+), 15 deletions(-)
>
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index b1d1949d24e2..4514188ff07c 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -1063,26 +1063,68 @@ static void gen_spr_7xx (CPUPPCState *env)
>
> #ifdef TARGET_PPC64
> #ifndef CONFIG_USER_ONLY
> -static void spr_read_uamr (DisasContext *ctx, int gprn, int sprn)
> +static void spr_write_amr(DisasContext *ctx, int sprn, int gprn)
> {
> - gen_load_spr(cpu_gpr[gprn], SPR_AMR);
> - spr_load_dump_spr(SPR_AMR);
> -}
> + TCGv t0 = tcg_temp_new();
> + TCGv t1 = tcg_temp_new();
> + TCGv t2 = tcg_temp_new();
>
> -static void spr_write_uamr (DisasContext *ctx, int sprn, int gprn)
> -{
> - gen_store_spr(SPR_AMR, cpu_gpr[gprn]);
> + /* Note, the HV=1 PR=0 case is handled earlier by simply using
> + * spr_write_generic for HV mode in the SPR table
> + */
> +
> + /* Build insertion mask into t1 based on context */
> + if (ctx->pr) {
> + gen_load_spr(t1, SPR_UAMOR);
> + } else {
> + gen_load_spr(t1, SPR_AMOR);
> + }
> +
> + /* Mask new bits into t2 */
> + tcg_gen_and_tl(t2, t1, cpu_gpr[gprn]);
> +
> + /* Load AMR and clear new bits in t0 */
> + gen_load_spr(t0, SPR_AMR);
> + tcg_gen_andc_tl(t0, t0, t1);
> +
> + /* Or'in new bits and write it out */
> + tcg_gen_or_tl(t0, t0, t2);
> + gen_store_spr(SPR_AMR, t0);
> spr_store_dump_spr(SPR_AMR);
> +
> + tcg_temp_free(t0);
> + tcg_temp_free(t1);
> + tcg_temp_free(t2);
> }
>
> -static void spr_write_uamr_pr (DisasContext *ctx, int sprn, int gprn)
> +static void spr_write_uamor(DisasContext *ctx, int sprn, int gprn)
> {
> TCGv t0 = tcg_temp_new();
> + TCGv t1 = tcg_temp_new();
> + TCGv t2 = tcg_temp_new();
> +
> + /* Note, the HV=1 case is handled earlier by simply using
> + * spr_write_generic for HV mode in the SPR table
> + */
>
> + /* Build insertion mask into t1 based on context */
> + gen_load_spr(t1, SPR_AMOR);
> +
> + /* Mask new bits into t2 */
> + tcg_gen_and_tl(t2, t1, cpu_gpr[gprn]);
> +
> + /* Load AMR and clear new bits in t0 */
> gen_load_spr(t0, SPR_UAMOR);
> - tcg_gen_and_tl(t0, t0, cpu_gpr[gprn]);
> - gen_store_spr(SPR_AMR, t0);
> - spr_store_dump_spr(SPR_AMR);
> + tcg_gen_andc_tl(t0, t0, t1);
> +
> + /* Or'in new bits and write it out */
> + tcg_gen_or_tl(t0, t0, t2);
> + gen_store_spr(SPR_UAMOR, t0);
> + spr_store_dump_spr(SPR_UAMOR);
> +
> + tcg_temp_free(t0);
> + tcg_temp_free(t1);
> + tcg_temp_free(t2);
> }
> #endif /* CONFIG_USER_ONLY */
>
> @@ -1094,15 +1136,17 @@ static void gen_spr_amr (CPUPPCState *env)
> * userspace accessible, 29 is privileged. So we only need to set
> * the kvm ONE_REG id on one of them, we use 29 */
> spr_register(env, SPR_UAMR, "UAMR",
> - &spr_read_uamr, &spr_write_uamr_pr,
> - &spr_read_uamr, &spr_write_uamr,
> + &spr_read_generic, &spr_write_amr,
> + &spr_read_generic, &spr_write_amr,
> 0);
> - spr_register_kvm(env, SPR_AMR, "AMR",
> + spr_register_kvm_hv(env, SPR_AMR, "AMR",
> SPR_NOACCESS, SPR_NOACCESS,
> + &spr_read_generic, &spr_write_amr,
> &spr_read_generic, &spr_write_generic,
> KVM_REG_PPC_AMR, 0);
> - spr_register_kvm(env, SPR_UAMOR, "UAMOR",
> + spr_register_kvm_hv(env, SPR_UAMOR, "UAMOR",
> SPR_NOACCESS, SPR_NOACCESS,
> + &spr_read_generic, &spr_write_uamor,
> &spr_read_generic, &spr_write_generic,
> KVM_REG_PPC_UAMOR, 0);
> spr_register_hv(env, SPR_AMOR, "AMOR",
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v2 01/10] ppc: Update SPR definitions, (continued)
- [Qemu-devel] [PATCH v2 01/10] ppc: Update SPR definitions, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 06/10] ppc: Initialize AMOR in PAPR mode, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 05/10] ppc: Add dummy SPR_IC for POWER8, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 03/10] ppc: Add a bunch of hypervisor SPRs to Book3s, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 04/10] ppc: Create cpu_ppc_set_papr() helper, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 10/10] ppc: A couple more dummy POWER8 Book4 regs, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 08/10] ppc: Add POWER8 IAMR register, Cédric Le Goater, 2016/03/16
- [Qemu-devel] [PATCH v2 09/10] ppc: Add dummy CIABR SPR, Cédric Le Goater, 2016/03/16