Re: [Qemu-devel] [RISU PATCH v3 03/18] risugen_x86_asm: add module

[Richard Henderson]

On 7/12/19 12:32 AM, Jan Bobek wrote:
> The module risugen_x86_asm.pm exports named register constants and
> asm_insn_* family of functions, which greatly simplify emission of x86
> instructions.
> 
> Signed-off-by: Jan Bobek <address@hidden>
> ---
>  risugen_x86_asm.pm | 918 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 918 insertions(+)
>  create mode 100644 risugen_x86_asm.pm

Clever use of token lists to make sure all state is processed as expected.  
Kudos!

Reviewed-by: Richard Henderson <address@hidden>


r~