Re: [Qemu-devel] [BUG] gcov support appears to be broken

[Alex Bennée]

Peter Maydell <address@hidden> writes:

> On Mon, 5 Aug 2019 at 11:39, Aleksandar Markovic <address@hidden> wrote:
>>
>> Hello, according to out docs, here is the procedure that should produce 
>> coverage report for execution of the complete "make check":
>>
>> #./configure --enable-gcov
>> #make
>> #make check
>> #make coverage-report
>>
>> It seems that first three commands execute as expected. (For example,
>> there are plenty of files generated by "make check" that would've not
>> been generated if "enable-gcov" hadn't been chosen.) However, the
>> last command complains about some missing files related to FP
>> support. If those files are added (for example, artificially, using
>> "touch <missing-file"), that it starts complaining about missing some
>> decodetree-generated files. Other kinds of files are involved too.

The gcov tool is fairly noisy about missing files but that just
indicates the tests haven't exercised those code paths. "make check"
especially doesn't touch much of the TCG code and a chunk of floating
point.

>>
>> It would be nice to have coverage support working. Please somebody
>> take a look, or explain if I make a mistake or misunderstood our gcov
>> support.

So your failure mode is no report is generated at all? It's working for
me here.

>
> Cc'ing Alex who's probably the closest we have to a gcov expert.
>
> (make/make check of a --enable-gcov build is in the set of things our
> Travis CI setup runs, so we do defend that part against regressions.)

We defend the build but I have just checked and it seems our
check_coverage script is currently failing:

  https://travis-ci.org/stsquad/qemu/jobs/567809808#L10328

But as it's an after_success script it doesn't fail the build.

>
> thanks
> -- PMM


--
Alex Bennée