[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 24/63] scsi: Rename TYPE_AM53C974_DEVICE to TYPE_PCI_ESP
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 24/63] scsi: Rename TYPE_AM53C974_DEVICE to TYPE_PCI_ESP |
Date: |
Thu, 3 Sep 2020 14:55:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> This will make the type name constant consistent with the name of
> the type checking macro.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Fam Zheng <fam@euphon.net>
> Cc: qemu-devel@nongnu.org
> ---
> hw/scsi/esp-pci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
> index 2ce96dc56e..2b1198380b 100644
> --- a/hw/scsi/esp-pci.c
> +++ b/hw/scsi/esp-pci.c
> @@ -35,11 +35,11 @@
> #include "qemu/module.h"
> #include "qom/object.h"
>
> -#define TYPE_AM53C974_DEVICE "am53c974"
> +#define TYPE_PCI_ESP "am53c974"
We are loosing information helpful to reviewers :(
- Re: [PATCH 20/63] pc87312: Rename TYPE_PC87312_SUPERIO to TYPE_PC87312, (continued)
[PATCH 18/63] mips: Rename TYPE_MIPS_BOSTON to TYPE_BOSTON, Eduardo Habkost, 2020/09/02
[PATCH 19/63] mptsas: Rename TYPE_MPTSAS1068 to TYPE_MPT_SAS, Eduardo Habkost, 2020/09/02
[PATCH 21/63] pxb: Rename TYPE_PXB_DEVICE to TYPE_PXB_DEV, Eduardo Habkost, 2020/09/02
[PATCH 22/63] pxb: Rename TYPE_PXB_PCIE_DEVICE to TYPE_PXB_PCIE_DEV, Eduardo Habkost, 2020/09/02
[PATCH 23/63] ramfb: Rename TYPE_RAMFB_DEVICE to TYPE_RAMFB, Eduardo Habkost, 2020/09/02
[PATCH 24/63] scsi: Rename TYPE_AM53C974_DEVICE to TYPE_PCI_ESP, Eduardo Habkost, 2020/09/02
- Re: [PATCH 24/63] scsi: Rename TYPE_AM53C974_DEVICE to TYPE_PCI_ESP,
Philippe Mathieu-Daudé <=
[PATCH 25/63] scsi: Rename TYPE_DC390_DEVICE to TYPE_DC390, Eduardo Habkost, 2020/09/02
[PATCH 27/63] sun4u: Rename TYPE_SUN4U_MEMORY to TYPE_SUN4U_RAM, Eduardo Habkost, 2020/09/02
[PATCH 26/63] sun4m: Rename TYPE_SUN4M_MEMORY to TYPE_SUN4M_RAM, Eduardo Habkost, 2020/09/02
[PATCH 28/63] tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB, Eduardo Habkost, 2020/09/02
[PATCH 29/63] versatile: Rename TYPE_VERSATILE_PCI_HOST to TYPE_PCI_VPB_HOST, Eduardo Habkost, 2020/09/02
[PATCH 30/63] versatile: Rename TYPE_VERSATILE_PCI to TYPE_PCI_VPB, Eduardo Habkost, 2020/09/02
[PATCH 31/63] virtio-console: Rename TYPE_VIRTIO_CONSOLE_SERIAL_PORT to TYPE_VIRTIO_CONSOLE, Eduardo Habkost, 2020/09/02