[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/33] target/mips: Convert MSA load/store instruction format
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 15/33] target/mips: Convert MSA load/store instruction format to decodetree |
|
Date: |
Sun, 24 Oct 2021 13:18:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/24/21 06:53, Richard Henderson wrote:
> On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote:
>> +#define TRANS_DF_E(NAME, trans_func, gen_func) \
>> + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \
>> + gen_func##_b, gen_func##_h, gen_func##_w,
>> gen_func##_d)
>
> I think this would be better as a table.
>
> #define TRANS_DF_E(NAME, trans_func, gen_func) \
> static void (* const NAME##_tab[4])(TCGv_ptr, TCGv_i32, TCGV) = { \
> gen_func##_b, gen_func##_h, gen_func##_w, gen_func##_d) \
> }; \
> TRANS_MSA(trans_func, NAME##_tag[a->df])
Nice tip! Thanks :>
- [PATCH 11/33] target/mips: Convert MSA I5 instruction format to decodetree, (continued)
- [PATCH 11/33] target/mips: Convert MSA I5 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 12/33] target/mips: Convert MSA BIT instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 14/33] target/mips: Convert MSA I8 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 15/33] target/mips: Convert MSA load/store instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 16/33] target/mips: Convert MSA 2RF instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 17/33] target/mips: Convert MSA FILL opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
[PATCH 18/33] target/mips: Convert MSA 2R instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
[PATCH 19/33] target/mips: Convert MSA VEC instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23