Re: [PATCH 12/33] target/mips: Convert MSA BIT instruction format to dec

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/33] target/mips: Convert MSA BIT instruction format to dec

From:	Richard Henderson
Subject:	Re: [PATCH 12/33] target/mips: Convert MSA BIT instruction format to decodetree
Date:	Sat, 23 Oct 2021 19:45:17 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote:

  @u5                 ...... ... df:2 sa:5  ws:5 wd:5 ......  &msa_ldst
  @s5                 ...... ... df:2 sa:s5 ws:5 wd:5 ......  &msa_ldst
  @ldi                ...... ... df:2 sa:s10     wd:5 ......  &msa_ldst ws=0
+@bit                ...... ... df:7       ws:5 wd:5 ......  &msa_ldst sa=0

Not sure why you seem over-keen to use &msa_ldst, with fields that don't apply to theseinsns. Drop that and you can more properly name the field dfm.

+    twd = tcg_const_i32(a->wd);
+    tws = tcg_const_i32(a->ws);


tcg_constant_i32.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 07/33] target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v, (continued)
- [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree, Richard Henderson, 2021/10/23
- [PATCH 09/33] target/mips: Introduce generic TRANS_CHECK() for decodetree helpers, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 09/33] target/mips: Introduce generic TRANS_CHECK() for decodetree helpers, Richard Henderson, 2021/10/23
- [PATCH 10/33] target/mips: Extract df_extract() helper, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 10/33] target/mips: Extract df_extract() helper, Richard Henderson, 2021/10/23
- [PATCH 11/33] target/mips: Convert MSA I5 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 11/33] target/mips: Convert MSA I5 instruction format to decodetree, Richard Henderson, 2021/10/23
- [PATCH 12/33] target/mips: Convert MSA BIT instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 12/33] target/mips: Convert MSA BIT instruction format to decodetree, Richard Henderson <=
- [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree, Richard Henderson, 2021/10/23
- [PATCH 14/33] target/mips: Convert MSA I8 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 14/33] target/mips: Convert MSA I8 instruction format to decodetree, Richard Henderson, 2021/10/23
- [PATCH 15/33] target/mips: Convert MSA load/store instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 15/33] target/mips: Convert MSA load/store instruction format to decodetree, Richard Henderson, 2021/10/24
    - Re: [PATCH 15/33] target/mips: Convert MSA load/store instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/24
- [PATCH 16/33] target/mips: Convert MSA 2RF instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 16/33] target/mips: Convert MSA 2RF instruction format to decodetree, Richard Henderson, 2021/10/24
- [PATCH 17/33] target/mips: Convert MSA FILL opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23

Prev by Date: Re: [PATCH 10/33] target/mips: Extract df_extract() helper
Next by Date: Re: [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree
Previous by thread: [PATCH 12/33] target/mips: Convert MSA BIT instruction format to decodetree
Next by thread: [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree
Index(es):
- Date
- Thread