Re: [PATCH 07/33] target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v

[Richard Henderson]

On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote:
> This 'shift amount' format is not always 16-bit, so name it
> generically as 'sa'. This will help to unify the various
> arg_msa decodetree generated structures.
>
> Rename the @bz format -> @bz_v (specific @bz with df=3) and
> @bz_df -> @bz (generic @bz).
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/mips/tcg/msa.decode      | 15 +++++++--------
>   target/mips/tcg/msa_translate.c | 20 ++++++++++----------
>   2 files changed, 17 insertions(+), 18 deletions(-)
>
> diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode
> index 74d99f6862c..aa784cf12a9 100644
> --- a/target/mips/tcg/msa.decode
> +++ b/target/mips/tcg/msa.decode
> @@ -13,19 +13,18 @@
>   
>   &r                  rs rt rd sa
>   
> -&msa_bz             df wt s16
> +&msa_bz             df       wt sa

Tab or odd spacing?  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~