[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 25/26] target/arm: Fix sve predicate store, 8 <= VQ <= 15
From: |
Peter Maydell |
Subject: |
[PULL 25/26] target/arm: Fix sve predicate store, 8 <= VQ <= 15 |
Date: |
Fri, 23 Jun 2023 13:31:34 +0100 |
From: Richard Henderson <richard.henderson@linaro.org>
Brown bag time: store instead of load results in uninitialized temp.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1704
Reported-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20230620134659.817559-1-richard.henderson@linaro.org
Fixes: e6dd5e782be ("target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld,
st}r")
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/arm/tcg/translate-sve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index ff050626e66..225d358922c 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -4329,7 +4329,7 @@ void gen_sve_str(DisasContext *s, TCGv_ptr base, int vofs,
/* Predicate register stores can be any multiple of 2. */
if (len_remain >= 8) {
t0 = tcg_temp_new_i64();
- tcg_gen_st_i64(t0, base, vofs + len_align);
+ tcg_gen_ld_i64(t0, base, vofs + len_align);
tcg_gen_qemu_st_i64(t0, clean_addr, midx, MO_LEUQ | MO_ATOM_NONE);
len_remain -= 8;
len_align += 8;
--
2.34.1
- [PULL 14/26] target/arm: Use get_phys_addr_with_struct in S1_ptw_translate, (continued)
- [PULL 14/26] target/arm: Use get_phys_addr_with_struct in S1_ptw_translate, Peter Maydell, 2023/06/23
- [PULL 16/26] target/arm: Use get_phys_addr_with_struct for stage2, Peter Maydell, 2023/06/23
- [PULL 15/26] target/arm: Move s1_is_el0 into S1Translate, Peter Maydell, 2023/06/23
- [PULL 17/26] target/arm: Add GPC syndrome, Peter Maydell, 2023/06/23
- [PULL 21/26] docs/system/arm: Document FEAT_RME, Peter Maydell, 2023/06/23
- [PULL 23/26] target/arm: Restructure has_vfp_d32 test, Peter Maydell, 2023/06/23
- [PULL 18/26] target/arm: Implement GPC exceptions, Peter Maydell, 2023/06/23
- [PULL 24/26] hw/arm/sbsa-ref: add ITS support in SBSA GIC, Peter Maydell, 2023/06/23
- [PULL 22/26] host-utils: Avoid using __builtin_subcll on buggy versions of Apple Clang, Peter Maydell, 2023/06/23
- [PULL 26/26] pc-bios/keymaps: Use the official xkb name for Arabic layout, not the legacy synonym, Peter Maydell, 2023/06/23
- [PULL 25/26] target/arm: Fix sve predicate store, 8 <= VQ <= 15,
Peter Maydell <=
- Re: [PULL 00/26] target-arm queue, Richard Henderson, 2023/06/25