[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 5/6] openpic: BRR1 is not a CPU-specific register.
From: |
Scott Wood |
Subject: |
[Qemu-ppc] [PATCH 5/6] openpic: BRR1 is not a CPU-specific register. |
Date: |
Thu, 13 Dec 2012 20:12:03 -0600 |
It's in the address range that normally contains a magic redirection
to the CPU-specific region of the curretn CPU, but it isn't actually
a per-CPU register. On real hardware BRR1 shows up only at 0x40000,
not at 0x60000 or other non-magic per-CPU areas. Plus, this makes
it possible to read the register on the QEMU command line with "xp".
Signed-off-by: Scott Wood <address@hidden>
---
hw/openpic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/openpic.c b/hw/openpic.c
index c57a168..c0c4307 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -580,6 +580,8 @@ static uint64_t openpic_gbl_read(void *opaque, hwaddr addr,
unsigned len)
retval = 0x00000000;
break;
case 0x00: /* Block Revision Register1 (BRR1) */
+ retval = opp->brr1;
+ break;
case 0x40:
case 0x50:
case 0x60:
@@ -881,9 +883,6 @@ static uint32_t openpic_cpu_read_internal(void *opaque,
hwaddr addr,
dst = &opp->dst[idx];
addr &= 0xFF0;
switch (addr) {
- case 0x00: /* Block Revision Register1 (BRR1) */
- retval = opp->brr1;
- break;
case 0x80: /* PCTP */
retval = dst->pctp;
break;
--
1.7.9.5
[Qemu-ppc] [PATCH 5/6] openpic: BRR1 is not a CPU-specific register.,
Scott Wood <=
[Qemu-ppc] [PATCH 2/6] openpic: remove pcsr (CPU sensitivity register), Scott Wood, 2012/12/13
[Qemu-ppc] [PATCH 6/6] openpic: s/opp->nb_irqs -1/opp->nb_cpus - 1/, Scott Wood, 2012/12/13
[Qemu-ppc] [PATCH 3/6] openpic: support large vectors on FSL mpic, Scott Wood, 2012/12/13
Re: [Qemu-ppc] [PATCH 0/6] openpic: first batch of cleanups and minor fixes, Alexander Graf, 2012/12/14