Re: [Tinycc-devel] Small patch

[Thomas Preud'homme]

Le jeudi 31 janvier 2013 02:07:36, Domingo Alvarez Duarte a écrit :
> Also here :
> 
> static void asm_expr_logic(TCCState *s1, ExprValue *pe)
> {
>     int op;
>     ExprValue e2;
> 
>     asm_expr_prod(s1, pe);
>     for(;;) {
>         op = tok;
>         if (op != '&' && op != '|' && op != '^')
>             break;
>         next();
>         asm_expr_prod(s1, &e2);
>         if (pe->sym || e2.sym)
>             tcc_error("invalid operation with label");
>         switch(op) {
>         case '&':
>             pe->v &= e2.v;
>             break;
>         case '|':
>             pe->v |= e2.v;
>             break;
>         default:
>         case '^':  ///////////////////////////////////////what this case
> after default mean ????????
>             pe->v ^= e2.v;
>             break;
>         }
>     }
> }

Looks weird indeed but I am reluctant to change it when I don't know why it 
was done this way in the first place. Since the file was commited in one go, I 
can't see if this result from a mistake or if it was intentional. We can 
consider changing this and the other such example right after the release.

Thomas

signature.asc
Description: This is a digitally signed message part.