Re: [Monotone-devel] Re: Testsuite status (SoC)

[Nathaniel Smith]

On Wed, Jul 12, 2006 at 01:09:19AM -0500, Timothy Brownawell wrote:
> Everything seems to work now, and all the buildbots except win32 (which
> has a longstanding unit_tests failure, and what looks like a
> canonicalization issue in one of the new tests) are green.

Indeed.  Great work!

> The new testsuite seems to be "done" now, but some things aren't optimal
> yet. In particular I'd like to make tester fairly independent from the
> rest of monotone by factoring out sanity.{cc,hh} and dependencies into a
> libsanity or similar, and by making tester (and libsanity) not depend on
> paths.{cc,hh} or the vocab* files (or constants.{cc,hh}).
> 
> So far it looks like sanity and dependencies make very minimal use of
> these files, so this shouldn't be (much of) a problem. I'll post again
> when I have a better idea of exactly how much would need to be changed.

I can't really tell how important these refactorings are from your
description, but that's okay, because I trust your taste.  I do want
to just double-check that you're not doing more work in this
particular direction than you otherwise would, just because it's what
you wrote up for SoC -- IIUC, last year some of your time ended up
being used less effectively than it might have, because the project
you were worked on was superceded by the unfolding roster design
plans, but you kept on to make sure you fulfilled the SoC
requirements.  So, just re-emphasizing that if you feel like calling
the testsuite good enough and starting working on per-file DAGs or
building a better automate or whatever else, cool; and if not (or not
yet), cool too.

-- Nathaniel