PSPP-BUG: [patch #5402] RANK draft 1

[Ben Pfaff]

Follow-up Comment #12, patch #5402 (project pspp):

Here's a version that works with SPLIT FILE and GROUP.  Implementing it made
some weaknesses in sorting and casereaders apparent.  There is also a huge
amount of room for optimization.

Does this approach make sense to you?  There are no comments, but I hope it
is clear what is going on.

It doesn't do SPLIT FILE perfectly.  In particular, if you have multiple
discontiguous SPLIT FILE groups with the same split values, then they will
all be ranked together as one big group, but SPSS ranks each group
separately.  I had code that fixed this, but, um, it didn't work due to a
basic misconception of mine.  It should be easy to fix, but I don't have time
tonight.

I'm attaching a diff against CVS main and an incremental diff against your
patch.  They should be equivalent.  I'm also attaching the trivial test I
used, which is in fact the only testing I did.
    _______________________________________________________

Additional Item Attachment:

File name: rank2.patch                    Size:33 KB
blp\'s version - against CVS head
<http://savannah.gnu.org/patch/download.php?file_id=10809>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5402>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/