[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PSPP-BUG: [patch #5402] RANK draft 1

From: John Darrington
Subject: PSPP-BUG: [patch #5402] RANK draft 1
Date: Tue, 19 Sep 2006 20:23:20 +0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Debian/1.7.8-1

Follow-up Comment #3, patch #5402 (project pspp):

>  I think the casereader, casefile, fastfile, etc. changes are fine.

Do you think it could ever make sense to clone a destructive reader?  I was
wondering if I should assert that it was non destructive.

> Ditto for the dict_get_case_weight change. In general I'm in  favor of
replacing int by bool where appropriate. It's self-documenting.

I'll check those changes in soon.

> create_var_label gets the label wrong for SAVAGE. Maybe you should just
create a table of rank function names and then do
snprintf (label, lsize, "%s of %s", table[index], ranked_var_name); 
> Shorter code, easier to update too.

You're right.  This part of the code is not currently very pretty. 

> I don't like sort_criteria_single. I'd be okay with a function to do what
this function does if it initialized a struct sort_criteria provided by the
caller. But I don't like the idea of adding static data here.



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]