Re: [patch] Simplify ftconfig.h

[Werner LEMBERG]

> Yes, here's it is as a bundle of 5 intermediate commits.  As a
> reminder, to use it, do:
> 
> git remote add bundle /path/to/bundle
> git fetch bundle

Thanks!  I've normalized the commit messages by converting them to
proper ChangeLog entries, then committed to git.

Note, however, that there are serious issues which I ask you to fix
ASAP:

* After compiling the library with `make devel; make', compilation of
  the the demo programs fails with

    freetype2-demos/src/ftbench.c: In function ‘face_requester’:
      freetype2-demos/src/ftbench.c:165:5: warning:
        implicit declaration of function ‘FT_UNUSED’ 
[-Wimplicit-function-declaration]
       FT_UNUSED( face_id );
       ^~~~~~~~~
    freetype2-demos/src/ftbench.c:165:5: warning:
      nested extern declaration of ‘FT_UNUSED’ [-Wnested-externs]

    [...]

    /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld:
     ftbench.o: in function `face_requester':
       freetype2-demos/src/ftbench.c:165: undefined reference to `FT_UNUSED'

    [...]


* Compilation with

    make multi CC=c++

  now fails with

    In file included from freetype2/devel/ft2build.h:36:0,
                     from freetype2/src/base/ftsystem.c:28:
      freetype2/include/freetype/config/ftheader.h:52:24: error:
        expected declaration before ‘}’ token
     #define FT_END_HEADER  }
                            ^
    freetype2/include/freetype/config/ftconfig.h:48:1: note:
      in expansion of macro ‘FT_END_HEADER’
     FT_END_HEADER
     ^~~~~~~~~~~~~


* Compilation with

    make multi

  aborts with

  In file included from freetype2/src/pcf/pcfutil.c:35:0:
    freetype2/src/pcf/pcfutil.h:38:3: warning:
      return type defaults to ‘int’ [-Wreturn-type]
     FT_LOCAL( void )
     ^~~~~~~~
  freetype2/src/pcf/pcfutil.h: In function ‘FT_LOCAL’:
    freetype2/src/pcf/pcfutil.h:39:3: error:
      expected declaration specifiers before ‘BitOrderInvert’
     BitOrderInvert( unsigned char*  buf,
     ^~~~~~~~~~~~~~
  freetype2/src/pcf/pcfutil.h:42:3: error:
    expected declaration specifiers before ‘FT_LOCAL’
     FT_LOCAL( void )
     ^~~~~~~~
  freetype2/src/pcf/pcfutil.h:46:3: error:
    expected declaration specifiers before ‘FT_LOCAL’
     FT_LOCAL( void )
     ^~~~~~~~
  freetype2/src/pcf/pcfutil.c:42:3: error:
    expected declaration specifiers before ‘FT_LOCAL_DEF’
     FT_LOCAL_DEF( void )
     ^~~~~~~~~~~~
  freetype2/src/pcf/pcfutil.c:64:3: error:
    expected declaration specifiers before ‘FT_LOCAL_DEF’
     FT_LOCAL_DEF( void )
     ^~~~~~~~~~~~
  freetype2/src/pcf/pcfutil.c:83:3: error:
    expected declaration specifiers before ‘FT_LOCAL_DEF’
     FT_LOCAL_DEF( void )
     ^~~~~~~~~~~~
  freetype2/src/pcf/pcfutil.c:100:3: error:
    expected ‘{’ at end of input
     }
     ^
  freetype2/src/pcf/pcfutil.c:100:3: warning:
    control reaches end of non-void function [-Wreturn-type]
     }
     ^


    Werner