Re: [Gnumed-devel] [set|link]CommChannel, activating_patient

[Karsten Hilbert]

> >     # FIXME: should we support named channel types, too ?
> Do you mean arbitrarily named channel types? This requires some UI changes
No, only those that are already in the database.

> I have tied the _save_data method in PatientHolder to the dispatcher event 
> activating_patient
> produced by gmPatient, to save changes before changing patients, but 
> encountered an interesting problem:
> we use wxCallAfter ()  for responding to events, which means by the time this 
> event actually gets
> called, the patient has already been updated to the new one in 
> gmCurrentPatient.
This illustrates why it is not a good idea to push up
wxCallAfter too high into the event dispatching abstraction.
We lose track of the side effects.

> Currently I have stopped using wxCallAfter for this event: which means 
> background threads such 
> as gmBackendListener can't raise this event (should they ever, anyway, 
> changing patients in
> response to a backend event could be rather annoying)
No, they shouldn't.

> BTW, I'm finishing off demographics now. I'm wondering whether patient photos 
> should go in 
> the demographics or the documents service?
IMO documents service.

Karsten
-- 
GPG key ID E4071346 @ wwwkeys.pgp.net
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346