gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] new regression failures


From: Greg Troxel
Subject: Re: [gpsd-dev] new regression failures
Date: Sun, 10 Nov 2013 20:07:05 -0500
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/23.4 (berkeley-unix)

well that's kind of goofy, but I see how trying to end the test quickly
results in the danger of not waiting enough.

I wonder if the test output could somehow capture the wait time, so that
this could autotune.  Or I wonder if there's some underlying bug to
chase.  Not that posix demands promptness, but still lack of it seems
ungood.

with this, things are looking good, but I will need to search more

diff --git a/gps/fake.py b/gps/fake.py
index a8c7914..bb00a5e 100644
--- a/gps/fake.py
+++ b/gps/fake.py
@@ -84,7 +84,7 @@ import packet as sniffer
 # the pty layer or gpsd itself.  Removing this entirely was tried but
 # caused failures under NetBSD.  Values smaller than the system timer
 # tick don't make any difference here.
-WRITE_PAD = 0.001
+WRITE_PAD = 0.004
 
 # We delay briefly after a GPS source is exhausted before removing it.
 # This should give its subscribers time to get gpsd's response before
@@ -94,7 +94,7 @@ WRITE_PAD = 0.001
 # underneath will return with precision finer than 1 second. (Linux
 # and *BSD return full precision.) Dropping this to 0.1 has been
 # tried but caused failures.
-CLOSE_DELAY = 0.2
+CLOSE_DELAY = 0.8
 
 class TestLoadError(exceptions.Exception):
     def __init__(self, msg):


0.001/0.4 was not ok

Attachment: pgpPKqo4_zg4O.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]