Re: ✘ Release blockers?

[Bernd Zeimetz]

On 2019-12-18 10:02, Fred Wright wrote:
> > We do test on clang.  I test on osX which uses clang.  But I see I do 
> > not
> > have Qt enabled.  Not sure how to do that on a mac.
>
> If you have MacPorts installed, just install the qt4-mac port.  At one
> time I also had builds with Qt5 working on the Mac, but something
> changed that broke it since then, so for now it's Qt4-only.

qt4 is deprecated and should be gone for good for a long time.
Nothing serious should use it anymore.


> > > It also only happens with
> > > qt=yes, but qt=no is forced if pkg-config can't find QtNetwork,
> > > explaining non-failures in certain cases.
> >
> > The only Qt thing gpsd builds is a simple test case.  No known 
> > clients.
>
> Yeah, I know, but at least the simple test should build and run.

It does everywhere else, can you please show at least a log of the 
failure?



> > > The fix is just to add timespec_str.c to the list of sources that get
> > > compiled as C rather than C++ in the C++ build, but I need to fully
> > > test that,
> >
> > We used to do something similar, it broke other things.
>
> It's worked in all the cases I've tried, and it just mimics what was
> already being done for several other modules.
>
> > Please do some tests, time is running out before the next release.
>
> I've pushed several commits to fix a number of problems.


Looking at your commits, I'm wondering about

commit c1ddef44be2e7636b9ff2b55e51f78e37bae411f
Author: Fred Wright <address@hidden>
Date:   Wed Dec 18 00:01:53 2019 -0800

    SConstruct: Fix potential build crash with some compilers.

How should that case happen?

         if c_only in qt_flags:
-            qt_flags.remove(c_only)
+            try:
+                qt_flags.remove(c_only)
+            except ValueError:
+                pass


If c_only disappears from qt_flags before it is being removed,
there is something completely broken. Not sure what you are trying to
fix there. Note the 'if c_only in qt_flags' line.

So what did you actually try to do here? Guess you had a reason for
that change?


Bernd




--
 Bernd Zeimetz                            Debian GNU/Linux Developer
 http://bzed.de                                http://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F