Re: [Mldonkey-users] output of client_stats

[Andre Hinrichs]

Am Donnerstag, 26. Dezember 2002 19:58 schrieb Michael Panteleit:
> I build me a prompt for the telnet interface and fiddled a little bit
> with a script and the output of client_stats.
>
> Isn't this much prettier?  :)
>
> Uptime: 19805  0+05:30
>       Client  seen       | Downloads  |  Uploads   |  Banned
>        Total  1824 100.0%| 505.8  26.2| 197.4  10.2| 124 6.8%
>      eDonkey    22   1.2%| 234.6  12.1|  18.6   1.0|   0 0.0%
> old mldonkey    40   2.2%|  59.1   3.1|  41.8   2.2|   0 0.0%
> new mldonkey   134   7.3%|  54.2   2.8|  46.1   2.4|   2 1.5%
>      Overnet    50   2.7%|  42.4   2.2|   0.0   0.0|   0 0.0%
>    old eMule     0   0.0%|   0.0   0.0|   0.0   0.0|   0 0.0%
>    new eMule  1578  86.5%| 115.6   6.0|  90.9   4.7| 122 7.7%
>
> It's clients seen, d/l in MB, d/l in kB/s, same for u/l and the
> banned, percentage in clients banned per that clients total.
>
> This could be easily implemented in the core guess.

Looks good, but there seems to be an error in your parser:
The sum of all percentages does not result into 100.
BTW, how do you compute the percentages in the 'Total' line?

Additionaly I would suggest some things on that:

1. Add braces around percentages like
Total  1824 (100.0%)| 505.8  (26.2)| 197.4  (10.2)| 124 (6.8%)

2. Fix width of percentages and add the percent sign:
Total  1824 (100.0%)| 505.8  ( 26.2%)| 197.4  ( 10.2%)| 124 (  6.8%)

3. Add a separator between the first two fields:
Total | 1824 (100.0%)| 505.8  ( 26.2%)| 197.4  ( 10.2%)| 124 (  6.8%)

4. Add some spaces:
Total | 1824 (100.0%) | 505.8  ( 26.2%) | 197.4  ( 10.2%) | 124 (  6.8%)

5. I would suggest an additional separator line.


The complete output would the look like this:

Uptime: 19805 (0+05:30)
      Client | seen          | Downloads      | Uploads        | Banned
-------------+---------------+----------------+----------------+-------------
       Total | 1824 (100.0%) | 505.8 ( 26.2%) | 197.4 ( 10.2%) | 124 (  6.8%)
     eDonkey |   22 (  1.2%) | 234.6 ( 12.1%) |  18.6 (  1.0%) |   0 (  0.0%)
old mldonkey |   40 (  2.2%) |  59.1 (  3.1%) |  41.8 (  2.2%) |   0 (  0.0%)
new mldonkey |  134 (  7.3%) |  54.2 (  2.8%) |  46.1 (  2.4%) |   2 (  1.5%)
     Overnet |   50 (  2.7%) |  42.4 (  2.2%) |   0.0 (  0.0%) |   0 (  0.0%)
   old eMule |    0 (  0.0%) |   0.0 (  0.0%) |   0.0 (  0.0%) |   0 (  0.0%)
   new eMule | 1578 ( 86.5%) | 115.6 (  6.0%) |  90.9 (  4.7%) | 122 (  7.7%)



Bye
Andre