[Octave-patch-tracker] [patch #8919] Start of patch to enable visibility attributes for GCC in build system

[Markus Mützel]

Follow-up Comment #9, patch #8919 (project octave):

Compilation of Octave with these patches with MXE Octave went smoothly.
But looking at the symbols that are exported from liboctave-8.dll, there seem
to be quite a few which are instantiations of standard library templates(?).
E.g. (among a lot of other similar ones):

_ZNSt10unique_ptrIA_10idx_vectorSt14default_deleteIS1_EED1Ev
_ZNSt10unique_ptrIA_5ArrayIxESt14default_deleteIS2_EED1Ev
_ZNSt10unique_ptrIA_NSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESt14default_deleteIS6_EED1Ev
_ZNSt10unique_ptrIN10idx_vector14idx_vector_repESt14default_deleteIS1_EED1Ev
_ZNSt10unique_ptrIN6octave16action_container4elemESt14default_deleteIS2_EED1Ev
_ZNSt11_Deque_baseI14sortrows_run_tSaIS0_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseI14sortrows_run_tSaIS0_EED2Ev
_ZNSt11_Deque_baseIPN6octave16action_container4elemESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseIPN6octave16action_container4elemESaIS3_EED2Ev
_ZNSt11_Deque_baseISt4pairIPK10octave_intIaExESaIS5_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPK10octave_intIaExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPK10octave_intIhExESaIS5_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPK10octave_intIhExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPK10octave_intIiExESaIS5_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPK10octave_intIiExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPK10octave_intIjExESaIS5_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPK10octave_intIjExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPK10octave_intIsExESaIS5_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPK10octave_intIsExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPK10octave_intItExESaIS5_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPK10octave_intItExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPK10octave_intIxExESaIS5_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPK10octave_intIxExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPK10octave_intIyExESaIS5_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPK10octave_intIyExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEExESaIS9_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKP22octave_idx_vector_sortxESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKP23octave_sparse_sort_idxlxESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKSt7complexIdExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKSt7complexIfExESaIS5_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKbxESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPKbxESaIS3_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKcxESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPKcxESaIS3_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKdxESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPKdxESaIS3_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKfxESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPKfxESaIS3_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKixESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPKixESaIS3_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKlxESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPKlxESaIS3_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKsxESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPKsxESaIS3_EED2Ev
_ZNSt11_Deque_baseISt4pairIPKxxESaIS3_EE17_M_initialize_mapEy
_ZNSt11_Deque_baseISt4pairIPKxxESaIS3_EED2Ev
_ZNSt11_Deque_baseIySaIyEED2Ev


Also the symbols from gnulib seem to be exported still.

This might be because we are linking with `-Wl,--export-all-symbols` for
Windows (mingw). It looks like this overrides the visibility flags set for
compilation.

That flag was added in this changeset for Java support:
https://hg.savannah.gnu.org/hgweb/octave/rev/db4453f40550

What was broken before this flag was added?
Could we link without the `--export-all-symbols` flag?


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?8919>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/