Re: [Monotone-devel] Re: Bug in CRLF conversions

[Richard Levitte - VMS Whacker]

In message <address@hidden> on Wed, 1 Feb 2006 14:13:18 +1100, Matthew Hannigan 
<address@hidden> said:

mlh> On Tue, Jan 31, 2006 at 07:50:51AM -0500, Yury Polyanskiy wrote:
mlh> > Again: solution is trivial. "Transform what I ask you to
mlh> > (LF->CRLF and back) and don't mess with anything special (like
mlh> > CR->CRLF etc)."
mlh> 
mlh> The other nice thing about this is that it's perfectly
mlh> reversible, even for 'binary' files.

Provided CRLF would be the internal normal line end form.  It is
currently not, so the real transformation on commit would be
CRLF->LF.  Then, when checking out, the reverse transformation would
occur, LF->CRLF.  Here's where the fun start, what do you think
happens if said binary had an embedded LF somewhere to begin with?

Do you suggest that monotone should have CRLF as the internal normal
line end form?

mlh> On a slightly different note, perhaps it would be best
mlh> for monotone to store the literal version and only transform
mlh> for the purposes of diffing or checksumming/sigs.

What about programs on other platforms than your own that choke on
your line endings?

If it wouldn't be for the differences in standard line end between
some platforms, I'd entirely agree with you.

Cheers,
Richard

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"When I became a man I put away childish things, including
 the fear of childishness and the desire to be very grown up."
                                                -- C.S. Lewis