emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New fu


From: Eli Zaretskii
Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function.
Date: Wed, 14 Jun 2023 14:35:52 +0300

> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: emacs-devel@gnu.org
> Date: Wed, 14 Jun 2023 11:18:20 +0100
> 
> >>   There is no need to mention files such as NEWS and MAINTAINERS, or to
> >>   indicate regeneration of files such as 'lib/gnulib.mk', in the
> >>   ChangeLog entry.  "There is no need" means you don't have to, but you
> >>   can if you want to.
> >>
> >> Should that text perhaps be updated?
> >
> > Why? the last sentence already covers my request, doesn't it?
> 
> It seemed to me that the text should say that it's considered preferable
> to mention them.  The current text leaves it wholly up to an
> individual's inclination.

Which is basically the truth.  I personally prefer to mention every
file, but I don't feel like making my preferences codified and carved
in stone.

> >> > As for the name of the new function: what do people think about
> >> > renaming it to eval-interactive-spec?  I don't think we need the
> >> > "command" part.
> >>
> >> In that case, what would we rename advice-eval-interactive-spec to, when
> >> we drop the 'advice-' prefix?
> >
> > That function exists for quite some time, so renaming it is a much
> > harder decision.
> 
> If we decide not to rename it, wouldn't it then be confusing to have
> advice-eval-interactive-spec and eval-interactive-spec taking different
> kinds of argument, with no indication in their name about the difference?

We use aliases to prevent such confusion.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]