Re: Quectel FW version - Merge Request

[Gary E. Miller]

Yo Jared!

On Mon, 7 Mar 2022 18:07:50 +0000
Jared Hagel <jared.hagel@vontas.com> wrote:

> > Odd,  you should be able to fork gpsd into your own GitLab account.
> > But I admit to being too lazy to do that.  What is your GitLab
> > handle?  I'll add it to gpsd project.  
> 
> I'm not sure what you mean by handle. Here is some information about
> my GitLab account. Is this enough? User ID: 9572988
> Full name: Jared Hagel
> Email: jared.hagel@vontas.com

Dunno, I'll try.  My GitLab login (handle) is @garyedmundsmiller.

> > I'm not seeing the requested raw data log.  With that I can get my
> > own debug output.  
> 
> Unfortunately I'm not familiar with this process. From browsing
> around, it looks like I can use gpspipe to get the raw data log
> (gpspipe -R). To do this, would I start gpsd, then quickly after
> start gpspipe? The trouble I see here is that if I don't start
> gpspipe quickly enough I could miss the first bytes received from the
> GPS receiver. 

Easy to capture the startup:
    # gpsd /dev/ttyXXX
    # sleep 10
    # gpspipe -R -x 20 > data.raw

Notice I started gpsd without the "-n".  So the initialization happnes
after gpspipe starts to run.

> 
> > Codacy does not like the use of strlen(), use strnlen() instead.
> > Yes, the existing code has existing strlen() and that is slowly
> > getting replaced.  New code must meet new Codacy requirement.  
> 
> Changed to use sizeof. Let me know what you think.

Much better.

You need to rebase off current git.

The problem with always requesting the version still stands.

> > gpsd does not support undocuemnnted commands.  Please document it.  
> 
> I've just finished a bunch of digging, and I don't think this command
> is documented ☹ Unfortunately this command is necessary to get the
> Quectel version however (see

How can you use it if you don't know what it does?

> https://github.com/andrethemac/L76GLNSV4/issues/9#issuecomment-603474459
> "The person responding has been a little hard to follow, but they
> seem to be saying we need to use an undocumented PQVERNO command"). I
> hope this doesn’t prevent this change from getting merged in....


Lack of doc is always a show stopper for gpsd.  But, if you can figure
out what the message contains, then add comments in your code to
document it.  How many fields, what is in each field, what Quectel model
you see it in.

> I
> can email Quectel to see if they can provide me documentation for
> this command, and if they're OK with including this documentation in
> GPSD comments. Would you like me to do this?

Yes, please.

> > Check that subtype1 is empty first.  
> 
> Done

I guess I was unclear.

Check it is empty before requeting it again.  Not checking after the
duplicate requests are sent.

> I attached an updated patch.diff. Let me know what you think.

Better, we'll get there.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        gem@rellim.com  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

pgpVKadXV9Lbs.pgp
Description: OpenPGP digital signature