RE: Quectel FW version - Merge Request

[Jared Hagel]

Hi Gary,

> Many ways to skin that catn but gpspipe is not one of them.  here is my first 
> choice:

> $ gpsdecode -D 4 < data.raw

Good to know. Thanks - I'll use this in the future.

> Much better, marged, a few style things I'll fix.

I looked over what you checked in -- thanks for the improvements. I tested the 
current git & it works for us. Do you know if these changes will be included in 
the next release of GPSD, and when approximately the release will be?

Thanks!
Jared

-----Original Message-----
From: gpsd-dev <gpsd-dev-bounces+jared.hagel=vontas.com@nongnu.org> On Behalf 
Of Gary E. Miller
Sent: Wednesday, March 9, 2022 5:17 PM
To: gpsd-dev@nongnu.org
Subject: Re: Quectel FW version - Merge Request

Yo Jared!

On Wed, 9 Mar 2022 15:24:30 +0000
Jared Hagel <jared.hagel@vontas.com> wrote:

> > Notice I started gpsd without the "-n".  So the initialization 
> > happnes after gpspipe starts to run.
> 
> Thanks for the tip 😊 Attached is raw output from my testing - 
> data.raw.

Looks good, thankd.  It would be easier if they just sent me a sample part...

> How do you feed this back to GPSD - probably through gpspipe as well, 
> correct? I haven't done this myself yet, but the raw output should be 
> good.

Many ways to skin that catn but gpspipe is not one of them.  here is my first 
choice:

$ gpsdecode -D 4 < data.raw

> > You need to rebase off current git.  
> 
> Done. New patch file attached.

Your diff was backwards.  The minus (-) was what you added.

$ patch -p 5 < /tmp/patch.diff
patching file drivers/driver_nmea0183.c
Reversed (or previously applied) patch detected!  Assume -R? [n] y $

Much better, marged, a few style things I'll fix.

You are throwing away 2/3rds of the info in $PQVERNO, I'll fix that too.

You overwrote subtype, which has good data from PMTK705, so I put the $PQVERNO 
data in subtype1.

I added your data.raw as a regression test.

> > Lack of doc is always a show stopper for gpsd.  But, if you can 
> > figure out what the message contains, then add comments in your code 
> > to document it.  How many fields, what is in each field, what 
> > Quectel model you see it in.
> 
> Documentation for this command was provided to me by Quectel support.
> I added this documentation to the comments in the 
> 'processQuectelFWVersion' function.

Good.

> > I guess I was unclear.
> >Check it is empty before requeting it again.  Not checking after the 
> >duplicate requests are sent.
> 
> I think I got it this time.

Yup.
 
> I tried to create another merge request by sending an email, but I was 
> rejected again.

Email to the list?  How do you even do that?

> I tried by going through this webpage - 
> https://gitlab.com/gpsd/gpsd/-/merge_requests. I'm likely doing 
> something wrong.

I think I have to add you to the developer list.  I sent you and invite for 
that.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        gem@rellim.com  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin