|
From: | grischka |
Subject: | Re: [Tinycc-devel] improving get_tok_str |
Date: | Sat, 29 Mar 2014 15:24:08 +0100 |
User-agent: | Thunderbird 2.0.0.23 (Windows/20090812) |
Thomas Preudhomme wrote:
Le 2014-03-15 20:10, mobi phil a écrit :Hi, get_tok_str is called in several places with second parameter NULL, though inside members (thus dereferencing NULL) is possible. Probably this combination "bad" never happens, but would like to use this function to understand the code.Yes, it ought to be fixed. The solution would be simple: CValue cval; if (!cv) { cval.ull = 0; cv = &cval; }
That doesn't fix anything except that it allows adding invalid code more easily. ;) --- grischka
[Prev in Thread] | Current Thread | [Next in Thread] |