tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] improving get_tok_str


From: grischka
Subject: Re: [Tinycc-devel] improving get_tok_str
Date: Sat, 29 Mar 2014 19:45:08 +0100
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)

mobi phil wrote:
It is really fun to see so much activity the last days. Thanks!

I think I solved my problem that moment by calling.
get_tok_str(tok, &tokc));
versus
get_tok_str(tok, NULL);

After a bit of experience with the code, I could even accept that
the original behavior of the function is just fine.

What is missing is few lines more of comments. As with any code base once
you know it any piece of documentation becomes superfluous, but for newcomers the amount of comments will clearly decide the "should I stay or should I go" ;)

Sounds reasonable.  See:
    http://repo.or.cz/w/tinycc.git/commitdiff/0ac8aaab1b

(Btw. to me tinycc is too obscure to be nice in some aspects also,
but that one still belongs to the "look just once" category).

--- gr




reply via email to

[Prev in Thread] Current Thread [Next in Thread]