Re: [Tinycc-devel] improving get_tok_str

[Domingo Alvarez Duarte]

Also after using scan-build from llvm/clang as one of the tools to help find bugs, if we use http://clang-analyzer.llvm.org/annotations.html and make use of some annotations and allow tinycc to accept then we could have scan-build as one extra pass on the check list before commit.

Cheers !

On Sat, Mar 29, 2014 at 6:20 PM, mobi phil <address@hidden> wrote:

It is really fun to see so much activity the last days. Thanks!

I think I solved my problem that moment by calling.

get_tok_str(tok, &tokc));

versus

get_tok_str(tok, NULL);

After a bit of experience with the code, I could even accept that

the original behavior of the function is just fine.

What is missing is few lines more of comments. As with any code base once

you know it any piece of documentation becomes superfluous, but for newcomers

the amount of comments will clearly decide the "should I stay or should I go" ;)

I think people who have bit more insight into the architecture of tcc, could 

write valuable comments especially around core types and their fields and key 

functions.

Thanks

mobi

_______________________________________________
Tinycc-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/tinycc-devel