Re: [gcmd-dev] gcc-4.2 bug?

[Piotr Eljasiak]

> > > Although gcc-4.1 is default compiler for i386, gcc-4.2 is default 
> > > compiler for debian on amd64 now. So we should try to fix it...
> > > 
> > > I don't pretend i know any C. But 
> > > <http://www.thescripts.com/forum/thread568121.html> explains it quite 
> > > simple. Maybe buff.size() becomes unsigned when it gets out of range ?
> > > Or perhaps the check in line 88 can be done differently (calling for the 
> > > next error stop...)
> > > And if nothing else helps, then perhaps 
> > > <http://gcc.gnu.org/ml/gcc-help/2004-05/msg00047.html>
> > 
> > 
> > I believe I've fixed the problem with gcc-4.2. Could you verify it,
> > please? rev #1220 & #1221
> 
> Last Changed Rev: 1223
> 
> Can't build it on debian with gcc4.2
> 
> In file included from gnome-cmd-tags.cc:28:
> gnome-cmd-tags.h: In member function ‘const std::string&
> GnomeCmdFileMetadata::operator[](GnomeCmdTag)’:
> gnome-cmd-tags.h:578: error: no matching function for call to
> ‘join(const std::set<std::basic_string<char, std::char_traits<char>,
> std::allocator<char> >, std::less<std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > >,
> std::allocator<std::basic_string<char, std::char_traits<char>,
> std::allocator<char> > > >&, const char*&)’
> gnome-cmd-tags.cc: In member function ‘void
> GnomeCmdFileMetadata::addf(GnomeCmdTag, const gchar*, ...)’:
> gnome-cmd-tags.cc:88: warning: comparison between signed and unsigned
> integer expressions
> 

And now: rev #1224 & #1225?