Re: lynx-dev annoying blinking of lynx with ncurses

[Hataguchi Takeshi]

On Thu, 11 Oct 2001, Thomas E. Dickey wrote:

> On Thu, 11 Oct 2001, Atsuhito Kohda wrote:
> 
> > Hi all,
> >
> > I used to compile lynx with slang but, this time,
> > I try lynx with ncurses.  It is fine because it works
> > well with -use_mouse on kterm.
> >
> > But I found that lynx with ncurses blinks very much
> > than that with slang, for example, when I input one letter
> > (or character?) in text field (or form?) it blinks.
> > This is really annoying and it never occured with slang
> > version lynx.
> >
> > Is this well-known already and difficult to fix?
> 
> I think it depends on the page you're trying to view (there are some
> changes that people made to solve some not-very-well-specified problems
> with repainting after displaying CJK).  I can take a look at it if you

I don't know well about this problem, but it's probably a problem that
some curses library can't process multibyte characters well.

In LYRefreshEdit, there is a repainting which may be agaist this problem.
When I removed this repainting, I found a strange behavior like below.

  1. Enter the 4 Japanese letters in a form (fig3).
  2. Delete the first letter and then I found the last letter became
    another character, which was not expected there (fig4).

    fig3: http://www.t3.rim.or.jp/~patakuti/tmp/lynx/fig3.png
    fig4: http://www.t3.rim.or.jp/~patakuti/tmp/lynx/fig4.png

I think this patch will improve this problem and reduce the
whole page blinkings.  It's for 2.8.5dev.2.
--
Takeshi Hataguchi
E-mail: address@hidden

%%% Created Mon Oct 15 00:15:36 JST 2001 by target lynx.patch. %%%
diff -bru orig/lynx2-8-5/src/LYStrings.c lynx2-8-5/src/LYStrings.c
--- orig/lynx2-8-5/src/LYStrings.c      Thu Aug 16 07:09:52 2001
+++ lynx2-8-5/src/LYStrings.c   Sun Oct 14 21:48:24 2001
@@ -3475,11 +3475,22 @@
                    if (i < (nrdisplayed - 1))
                        buffer[1] = str[++i];
 #else /* SUPPORT_MULTIBYTE_EDIT */
+#ifndef USE_SLANG
+                   int ii, xx,yy;
+#endif /* USE_SLANG */
                    if (i < (nrdisplayed - 1)) {
                        buffer[1] = str[++i];
                        end_multi = 1;
                    } else
                        end_multi = 0;
+#ifndef USE_SLANG
+                   LYGetYX(yy, xx);
+                   for (ii=0; ii<strlen(buffer); ii++) {
+                       LYaddch(' ');
+                   }
+                   LYrefresh();
+                   LYmove(yy, xx);
+#endif /* USE_SLANG */
 #endif /* SUPPORT_MULTIBYTE_EDIT */
                    LYaddstr(buffer);
                    buffer[1] = '\0';
@@ -3542,12 +3553,6 @@
     }
 
     LYmove(edit->sy, edit->sx + Pos - DspStart);
-#ifdef SUPPORT_MULTIBYTE_EDIT
-#if (!USE_SLANG && !defined(USE_MULTIBYTE_CURSES))
-    if (HTCJK != NOCJK)
-       lynx_force_repaint();
-#endif /* !USE_SLANG && !defined(USE_MULTIBYTE_CURSES) */
-#endif /* SUPPORT_MULTIBYTE_EDIT */
 
 #ifdef USE_COLOR_STYLE
     if (estyle != NOSTYLE)

; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden