Re: [Mldonkey-users] Investigation: No download for some, full downloads for the other

[MLdonkey]

>  * it looks hackish, "if we don't know what this source is good for, ask for
>  everything", unless you can explain cases were it is the only thing mldonkey
>  can do;

Yes, it is a hack. But it worked good for me. Just don't apply it, and
test how many "Direct" locations you have in the GUI. For me, before
the patch, 100 % where direct, and 0% other. Now, I've 10 % indirect,
and I often download from them more than from direct connections.

>  * it will flood Lugdunum servers' test connections just as well as the plain
>  List.iter (...) !current-files

Yes, it will. We have to think how to detect such connections. Maybe
we can test if we are trying to connect to a server with the same IP ?

>  * here's how I think unknown incoming peers are greeted, tell me if my
>  expectations are wrong:
>    - when they connect, query_files is called; since the peer is not
>      known to be the source of anything, file requests aren't sent, and the
>      client_last_filereqs timer is not updated
>    - hopefully the incoming peer, at least, knows why it connected for, so it
>      sends its filerequests
>    - that calls add_new_location, that adds the file requested to the
>      client_source_for, and calls query_files again(*), so the first
>      filerequest, at least, is immediately echoed. Is it fine to send
>      filerequests at that time ?

No, this is only for incoming connections from downloaders. But a lot
of users are still Low-ID, and you can directly connect to them. So,
you ask the server to ask them to connect to you. Once, they have
connected, they have no idea about why they had to do that. It's now
your job to ask what you want. Of course, a better approach would be
to check if we recognize this client has a Low-ID client that we asked
to connect us to a server. It could probably be done (I don't remember
if the connect message contains the Low-ID, but it contains the server
address at least).

But Simon is in holidays now, so we will all have to wait for a week for
this to be implemented, unless some volunteer send a patch ...

- MLDonkey