Re: Make window-list return windows for all frames

[Arthur Miller]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sat, 17 Jun 2023 11:39:43 +0200
>> Cc: arthur.miller@live.com, gregory@heytings.org, emacs-devel@gnu.org
>> From: martin rudalics <rudalics@gmx.at>
>> 
>>  > Thanks.  then I guess we can install (on master) the patch which makes
>>  > window-list accept t as the FRAME argument.
>> 
>> I haven't seen the patch but I suppose that all it has to do is to skip
>> the
>> 
>>    if (!EQ (frame, XWINDOW (window)->frame))
>>      error ("Window is on a different frame");
>> 
>> check when FRAME is not a live frame.
>
> That, and a suitable change to the doc string, yes.

Hello,

can you please see if this is a suitable change?

I seem to have done one extra empty line cleanup this time; is that OK or are
there supposed to be two empty lines?


A side question (for anyone):

When runing ert in my normal Emacs with my configuration, I get this (top of)
stack trace:

(debugger-make-xrefs)
  (let ((debugger-previous-backtrace nil)) (debugger-make-xrefs))
  (save-restriction (narrow-to-region begin (point)) (let 
((debugger-previous-backtrace nil)) (debugger-make-xrefs)))
  (save-excursion (save-restriction (narrow-to-region begin (point)) (let 
((debugger-previous-backtrace nil)) (debugger-make-xrefs))))
  ert--make-xrefs-region(175 216)
  ....

But when I run ert in emacs -Q, it works fine, so it is obviously something in
my setup. Where to look for what is wrong, any advice on top of the head? Why
would xref be involved here? Any idea?

0001-Allow-t-for-FRAME-in-window-list.patch
Description: Text Data