emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make window-list return windows for all frames


From: martin rudalics
Subject: Re: Make window-list return windows for all frames
Date: Tue, 20 Jun 2023 08:25:55 +0200

> can you please see if this is a suitable change?

> +  if (!EQ (frame, XWINDOW (window)->frame) && !(BASE_EQ (frame, Qt)))

I would instead write

  if (FRAMEP (frame) && !EQ (XWINDOW (window)->frame, frame))

and get the first part of what you earlier described as

> Yes, window-list and window-list-1 becaomes the same, just with arguments in
> different order. Could even remove c version of window-list, and implement it 
as
> a call to window-list-1. Less code, less maintanance.

for free.  (If you also want to "remove c version of window-list", you
should teach run_window_configuration_change_hook to call window_list_1
first).

martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]