libunwind-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libunwind-devel] Plan for future releases?


From: David Abdurachmanov
Subject: Re: [Libunwind-devel] Plan for future releases?
Date: Tue, 23 Feb 2016 09:26:33 +0200

> On 23 Feb 2016, at 02:07, Arun Sharma <address@hidden> wrote:
> 
> On Sun, Feb 21, 2016 at 6:28 AM, David Abdurachmanov
> <address@hidden> wrote:
>> 
>>> On 14 Feb 2016, at 10:03, David Abdurachmanov <address@hidden> wrote:
>>> 
>>> I could run test suite on x86_64/CentOS 6 & 7, aarch64/CentOS 7,
>>> ppc64le/Fedora 22 and ppc64/Fedora 22 once you have release candidate.
> 
> Thanks for testing! Looks like the core file location is an issue. I'm
> happy to take a patch that makes it happy on these distros, but it
> doesn't sound like a hugely important issue for usability of the
> library.
> 
> I'll put up a 1.2-rc1 tar ball tonight.

Could you look into not upstreamed patch (20123007_workaround_test-ptrace.patch)
Debian has? Maybe it's valid for everyone and makes sense to pick it up.

## 20123007_workaround_test-ptrace.patch

Looks to be not upstreamed, prevents some crash (segfault).

Patch is small, here it is:

Index: libunwind/tests/test-ptrace.c
===================================================================
--- libunwind.orig/tests/test-ptrace.c  2012-07-30 10:05:35.271168000 +0100
+++ libunwind/tests/test-ptrace.c       2012-07-30 11:39:37.309158623 +0100
@@ -182,6 +182,11 @@

      /* automated test case */
      argv = args;
+
+      /* Unless the args array is 'walked' the child
+         process is unable to access it and dies with a segfault */
+      fprintf(stderr, "Automated test (%s,%s,%s,%s)\n",
+              args[0],args[1],args[2],args[3]);
    }
  else if (argc > 1)
    while (argv[optind][0] == '-')

Here are more tests.

## FreeBSD 10.2-STABLE + amd64

http://davidlt.web.cern.ch/davidlt/vault/libunwind/freebsd_10.2_stable_amd64.log
 // make check
http://davidlt.web.cern.ch/davidlt/vault/libunwind/test-suite_freebsd_10.2_stable_amd64.log

============================================================================
Testsuite summary for libunwind 1.1
============================================================================
# TOTAL: 32
# PASS:  23
# SKIP:  0
# XFAIL: 2
# FAIL:  7
# XPASS: 0
# ERROR: 0

## FreeBSD 11.0-CURRENT + amd64

http://davidlt.web.cern.ch/davidlt/vault/libunwind/freebsd_11.0_current_amd64.log
 // make check
http://davidlt.web.cern.ch/davidlt/vault/libunwind/test-suite_freebsd_11.0_current_amd64.log

Out of the box libunwind tests failed to build:

--- mapper.o ---
mapper.c:55:33: error: use of undeclared identifier 'MAP_NORESERVE'
                MAP_PRIVATE | MAP_ANONYMOUS | MAP_NORESERVE,
                                              ^
1 error generated.
*** [mapper.o] Error code 1

Quick patch attached.

============================================================================
Testsuite summary for libunwind 1.1
============================================================================
# TOTAL: 32
# PASS:  22
# SKIP:  0
# XFAIL: 2
# FAIL:  8
# XPASS: 0
# ERROR: 0

Extra failing test seems to be Ltest-varargs comparing to 10.2.

It would be nice to test on Fedora Rawhide as it has GCC 6.0.0 and glibc 2.23.

Attachment: 0001-Do-not-use-unimplemented-MAP_NORESERVE-mmap-flag-in-.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]