lynx-dev lynx -lss option bad [BSDI-Support-Request #53069]

[Jeffrey C Honig]

Here is a bug report we found by inspection.

Thanks.

Jeff

------- Forwarded Message

Date:           Fri, 17 Jul 1998 16:36:30 -0600
From:           Chris Kottaridis <address@hidden>
Subject:        lynx -lss option bad [BSDI-Support-Request #53069]
To:             address@hidden
cc:             address@hidden
X-Request-Do:   area problems
X-Request-Do:   class eng
X-Request-Number: 53069
X-Request-Owner: jch
X-Request-User: address@hidden
X-Request-Submitter: address@hidden
X-Request-Date: Sun Jul 19 16:32:58 1998 (900887578)
X-Request-QueueTime: Sun Jul 19 16:32:58 1998 (900887578)
X-Request-ResponseTime: Sun Jul 19 16:40:34 1998 (900888034)
X-Request-Status: open
X-Request-Priority: normal
X-Request-Updated: Sun Jul 19 16:40:34 1998 (900888034)
X-Request-Class: eng
X-Request-Area: bug
X-Request-Esclevel: 0
X-Mailer:       exmh version 1.6.9 8/22/96
Mime-Version:   1.0
Content-Type:   text/plain; charset=us-ascii
Sender:         address@hidden
Status:         U

I was perusing lynx2-8 for something different and ran across this code:

#if defined(USE_HASH)
            } else if (strncmp(buf, "-lss", 4) == 0) {
                if ((cp = strchr(buf,'=')) != NULL) {
                    StrAllocCopy(lynx_lss_file, cp+1);
                } else {
                    cp = buf;
                    while (*cp && !isspace((unsigned char)*cp))
                        cp++;
                    while (*cp && isspace((unsigned char)*cp))
                        cp++;
                    if (*cp)
                        StrAllocCopy(lynx_cfg_file, cp);
                }

I think the last StrAllocCopy should be to lynx_lss_file rather then
lynx_cfg_file. I think what it's trying to do here is allow the -lss
option to work either as:

- -lss=<filename>

or 

- -lss <filename>

The man page doesn't seem to mention anything about -lss though. I can't
imagine that if you don't use an "=" then the cfg file should be set
instead of the lss file though.

                Chris Kottaridis        (address@hidden)




===========================================================================
X-Request-Action: Class set to eng by address@hidden
X-Request-Action: Area changed to problems by address@hidden
X-Request-Acted: Sun Jul 19 16:32:58 1998 (900887578)

===========================================================================
X-Request-Action: Area changed to bug by tks.
X-Request-Acted: Sun Jul 19 16:40:29 1998 (900888029)

===========================================================================
X-Request-Action: Given to jch by tks.
X-Request-Acted: Sun Jul 19 16:40:34 1998 (900888034)


------- End of Forwarded Message